-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: add back the config command #907
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okwme
requested review from
alessio,
alexanderbez,
jgimeno,
yaruwangway and
zmanian
as code owners
July 14, 2021 15:59
Codecov Report
@@ Coverage Diff @@
## main #907 +/- ##
==========================================
+ Coverage 0.41% 12.00% +11.59%
==========================================
Files 7 10 +3
Lines 483 933 +450
==========================================
+ Hits 2 112 +110
- Misses 480 816 +336
- Partials 1 5 +4 |
okwme
changed the title
DRAFT: fix: add back the config command and run linting
R4R: fix: add back the config command and run linting
Jul 14, 2021
okwme
changed the title
R4R: fix: add back the config command and run linting
R4R: add back the config command
Jul 14, 2021
shahankhatch
approved these changes
Jul 14, 2021
okwme
added a commit
that referenced
this pull request
Jul 14, 2021
* fix: add back the config command and run linting * test: increase code coverage
okwme
added a commit
that referenced
this pull request
Jul 14, 2021
* fix: add back the config command and run linting * test: increase code coverage
okwme
added a commit
that referenced
this pull request
Aug 5, 2021
* Update changelog * Cherrypick dex v5 go.sum (#894) * Bump sdk, tendermint version of liquidity module (#891) * bump sdk, tendermint version of liquidity module * exclude LegacyAmino cases of lint * Update gaia module version to v5 (#892) * Update changelog * Update gaia package to v5 * Update go.sum (#893) Co-authored-by: dongsam <[email protected]> * Update changelog (#895) (#896) (cherry picked from commit aa38385) * Merge pull request #907: add back the config command (#908) * fix: add back the config command and run linting * test: increase code coverage * chore: update changelog (#909) * chore: update changelog (#909) (#910) * cherry pick 5 0 2 (#913) * Update RELEASING.md (#911) * chore: add artifacts to the gitignore (#912) * chore: update changelog (#914) (#915) * Rc0/v5.0.3 (#929) * chore: version bump SDK (#924) * chore: update sdk release (#928) * chore: update sdk release * Update CHANGELOG.md Co-authored-by: Aleksandr Bezobchuk <[email protected]> * Update CHANGELOG.md Co-authored-by: Aleksandr Bezobchuk <[email protected]> * chore: update changelog Co-authored-by: Jacob Gadikian <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Shahan Khatchadourian <[email protected]> Co-authored-by: dongsam <[email protected]> Co-authored-by: Jacob Gadikian <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #906
Description
Adds back the config command to
gaiad
and also run the linting command as outlined in CONTRIBUTING.mdFor contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)