Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: add back the config command #907

Merged
merged 2 commits into from
Jul 14, 2021
Merged

R4R: add back the config command #907

merged 2 commits into from
Jul 14, 2021

Conversation

okwme
Copy link
Contributor

@okwme okwme commented Jul 14, 2021

Closes: #906

Description

Adds back the config command to gaiad and also run the linting command as outlined in CONTRIBUTING.md


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #907 (03cfa8b) into main (08d5644) will increase coverage by 11.59%.
The diff coverage is 19.44%.

@@            Coverage Diff             @@
##            main     #907       +/-   ##
==========================================
+ Coverage   0.41%   12.00%   +11.59%     
==========================================
  Files          7       10        +3     
  Lines        483      933      +450     
==========================================
+ Hits           2      112      +110     
- Misses       480      816      +336     
- Partials       1        5        +4     

@okwme okwme changed the title DRAFT: fix: add back the config command and run linting R4R: fix: add back the config command and run linting Jul 14, 2021
@okwme okwme changed the title R4R: fix: add back the config command and run linting R4R: add back the config command Jul 14, 2021
@okwme okwme merged commit f0a904f into main Jul 14, 2021
@okwme okwme deleted the okwme/906-config-command branch July 14, 2021 17:03
okwme added a commit that referenced this pull request Jul 14, 2021
* fix: add back the config command and run linting

* test: increase code coverage
okwme added a commit that referenced this pull request Jul 14, 2021
* fix: add back the config command and run linting

* test: increase code coverage
okwme added a commit that referenced this pull request Aug 5, 2021
* Update changelog

* Cherrypick dex v5 go.sum (#894)

* Bump sdk, tendermint version of liquidity module (#891)

* bump sdk, tendermint version of liquidity module

* exclude LegacyAmino cases of lint

* Update gaia module version to v5 (#892)

* Update changelog

* Update gaia package to v5

* Update go.sum (#893)

Co-authored-by: dongsam <[email protected]>

* Update changelog (#895) (#896)

(cherry picked from commit aa38385)

* Merge pull request #907: add back the config command (#908)

* fix: add back the config command and run linting

* test: increase code coverage

* chore: update changelog (#909)

* chore: update changelog (#909) (#910)

* cherry pick 5 0 2 (#913)

* Update RELEASING.md (#911)

* chore: add artifacts to the gitignore (#912)

* chore: update changelog (#914) (#915)

* Rc0/v5.0.3 (#929)

* chore: version bump SDK (#924)

* chore: update sdk release (#928)

* chore: update sdk release

* Update CHANGELOG.md

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* chore: update changelog

Co-authored-by: Jacob Gadikian <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Shahan Khatchadourian <[email protected]>
Co-authored-by: dongsam <[email protected]>
Co-authored-by: Jacob Gadikian <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add back config command to gaiad
2 participants